RFR: 282: Make the review requirements more explicit in the progress list [v3]

[Magnus Ihse Bursie]

On Fri, 29 Apr 2022 23:34:56 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> That's fine, thanks!
>> 
>> I now realize that you put the space and parentheses in the string here. I think this method should just return the requirements and let the visitor add the surrounding formatting.
>
> Fixed.

@lgxbslgx I missed reviewing this when it was open, and am just going through the backlog of changes that has happened now.

However, I think this was incorrect. The code here makes the text appears as: 

Change must be properly reviewed (1 review required, with at least 1 reviewer)


when it should have been:

Change must be properly reviewed (1 review required, with at least 1 Reviewer)


(Note the capitalization of Reviewer).

Traditionally, the (not very clear, I admit) distinction has been made in OpenJDK between "reviewer" (anyone who offers a review) and a "Reviewer" (a member with the official status as Reviewer for a project). This text is about the latter, so changing the "r" to a "R" in the message made a significant difference.

Can you please fix this in a follow-up PR?

-------------

PR: https://git.openjdk.java.net/skara/pull/1305