RFR: 1437: Fix the OpenJDK official role name and pluralization [v2]

Guoxiong Li gli at openjdk.java.net
Thu May 12 03:38:44 UTC 2022


> Hi all,
> 
> This patch mainly fixes the following message:
> 
> 1. Remove the pluralization if these is 0 reviewer. `no reviews required` --> `no review required`
> 2. Fix the official role name. eg: `reviewer` --> `Reviewer`, `committers` --> `Committers`
> 3. Unify the comment and the progress message. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)`
> 4. Fix the pluralization of the comment. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)` Note the pluralization.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Add bylaws link of the role.

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/1319/files
  - new: https://git.openjdk.java.net/skara/pull/1319/files/c5fc2924..0042b23c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1319&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1319&range=00-01

  Stats: 149 lines in 4 files changed: 33 ins; 19 del; 97 mod
  Patch: https://git.openjdk.java.net/skara/pull/1319.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1319/head:pull/1319

PR: https://git.openjdk.java.net/skara/pull/1319


More information about the skara-dev mailing list