RFR: 1437: Fix the OpenJDK official role name and pluralization

Guoxiong Li gli at openjdk.java.net
Thu May 12 03:38:45 UTC 2022


On Wed, 11 May 2022 15:22:58 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch mainly fixes the following message:
> 
> 1. Remove the pluralization if these is 0 reviewer. `no reviews required` --> `no review required`
> 2. Fix the official role name. eg: `reviewer` --> `Reviewer`, `committers` --> `Committers`
> 3. Unify the comment and the progress message. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)`
> 4. Fix the pluralization of the comment. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)` Note the pluralization.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This link was added. And the tests were refactored to avoid some duplicated code. For convenience, I copy some messages/comments below for you to review:

The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 5 (with at least 1 [Lead](http://openjdk.java.net/bylaws#project-lead), 1 [Reviewer](http://openjdk.java.net/bylaws#reviewer), 1 [Committer](http://openjdk.java.net/bylaws#committer), 1 [Author](http://openjdk.java.net/bylaws#author), 1 [Contributor](http://openjdk.java.net/bylaws#contributor)).

The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 [Reviewer](http://openjdk.java.net/bylaws#reviewer), 1 [Author](http://openjdk.java.net/bylaws#author)).

The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 [Reviewers](http://openjdk.java.net/bylaws#reviewer)).

Change must be properly reviewed (5 reviews required, with at least 1 [Lead](http://openjdk.java.net/bylaws#project-lead), 1 [Reviewer](http://openjdk.java.net/bylaws#reviewer), 1 [Committer](http://openjdk.java.net/bylaws#committer), 1 [Author](http://openjdk.java.net/bylaws#author), 1 [Contributor](http://openjdk.java.net/bylaws#contributor))

Change must be properly reviewed (1 review required, with at least 1 [Reviewer](http://openjdk.java.net/bylaws#reviewer))

Change must be properly reviewed (2 reviews required, with at least 2 [Reviewers](http://openjdk.java.net/bylaws#reviewer))

-------------

PR: https://git.openjdk.java.net/skara/pull/1319


More information about the skara-dev mailing list