RFR: 1449: Changing the original hash in a backport PR doesn't work

Kevin Rushforth kcr at openjdk.java.net
Wed May 25 16:26:49 UTC 2022

On Wed, 25 May 2022 16:06:10 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> If a user tries to change the original hash for a backport PR, by changing the title to "Backport HASH", it appears to work, but in reality, several things behind the scenes do not. The logic for finding the original commit will always just return the first hash that was set and ignores any updates/changes. This affects the clean evaluation and the commit message.
> This patch changes the method for finding the original hash so that the last one is returned instead. A new test is added to verify this functionality, both for the clean evaluation as well as the final commit message.

Looks good.


Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1321

More information about the skara-dev mailing list