RFR: 1385: Backport MR links to the wrong CSR request [v6]

Erik Joelsson erikj at openjdk.java.net
Fri May 27 12:25:13 UTC 2022


On Fri, 27 May 2022 07:46:00 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch solves the wrong CSR in the backport PR. It mainly has the following rules:
>> 1. if the `version` in `.jcheck/conf` doesn't exist or the `version` is wrong, the bot think the CSR also doesn't exist.
>> 2. else, if the `version` in `.jcheck/conf` matches the fix version of the primary CSR, the bot will use the primary CSR. (primary CSR is the CSR of the primary issue)
>> 3. else, if these is a backport issue matches the `version`, the bot will find the CSR of the backport issue. If found, use it. If not, the bot think the CSR doesn't exist.
>> 4. else (no backport issue matches the `version`) the bot think the CSR doesn't exist.
>> 
>> The classes `CSRBot`, `CheckRun` and `CSRCommand` will handle the situations above respectively.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix log and comment.

Marked as reviewed by erikj (Lead).

-------------

PR: https://git.openjdk.java.net/skara/pull/1318


More information about the skara-dev mailing list