RFR: 1410: The reply message of the 'reviewers' command should be more accurate
Erik Joelsson
erikj at openjdk.java.net
Tue May 31 17:32:16 UTC 2022
On Sat, 28 May 2022 09:17:55 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> This trivial patch fixes the reply message of the `reviewers` command.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 123:
> 121: if (previous.isPresent()) {
> 122: if (roleIsLower(role, previous.get().role())) {
> 123: reply.println("Only the [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to lower the role for additional reviewers.");
Suggestion:
reply.println("Only [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to lower the role for additional reviewers.");
bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 127:
> 125: }
> 126: if (numReviewers < previous.get().number()) {
> 127: reply.println("Only the [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to decrease the number of required reviewers.");
Suggestion:
reply.println("Only [Reviewers](https://openjdk.java.net/bylaws#reviewer) are allowed to decrease the number of required reviewers.");
-------------
PR: https://git.openjdk.java.net/skara/pull/1326
More information about the skara-dev
mailing list