RFR: 1393: PR bot fails on missing .jcheck/conf
Zhao Song
zsong at openjdk.org
Tue Nov 1 17:18:50 UTC 2022
On Mon, 31 Oct 2022 22:39:34 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> Instead of explicitly checking for `.jcheck/conf` here through a remote call, I think it would be better to react to if the `Optional<CensusInstance>` below comes back empty or not. If it's empty and `bot.confOverrideRepository().isEmpty()` then you can print a message.
Yesterday I was wondering whether there is any possible that `Optional<CensusInstance>` is empty due to other errors. Today I read through the code again and confirm that Only `.jcheck/conf` invalid or missing will make `Optional<CensusInstance>` empty. Thx!
-------------
PR: https://git.openjdk.org/skara/pull/1407
More information about the skara-dev
mailing list