RFR: 1393: PR bot fails on missing .jcheck/conf [v2]

[Erik Joelsson]

On Tue, 1 Nov 2022 18:45:21 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> SKARA-1393 describes a problem related with `.jcheck/conf` missing.
>> 
>> In this patch, when the problem happens, the author of this pull request will get instructions about how to solve this problem.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   SKARA-1217

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 234:

> 232:             census = CensusInstance.createCensusInstance(hostedRepositoryPool, bot.censusRepo(), bot.censusRef(), scratchPath.resolve("census"), pr,
> 233:                     bot.confOverrideRepository().orElse(null), bot.confOverrideName(), bot.confOverrideRef()).orElseThrow();
> 234:         } catch (InvalidJCheckConfException invalidJCheckConfException) {

Please just name the caught exception variable `e` unless we need explicit names.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/LimitedCensusInstance.java line 17:

> 15: import org.openjdk.skara.jcheck.JCheckConfiguration;
> 16: 
> 17: class InvalidJCheckConfException extends RuntimeException {

I would like this to be a checked exception, so just extend `Exception`.

-------------

PR: https://git.openjdk.org/skara/pull/1407