Integrated: 1587: Adding review comments should not mean approval status change

[Zhao Song]

On Wed, 19 Oct 2022 19:22:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

> The issue here is ' if a user leaves additional comments using the "Review changes" dialog, and selects the "Comments", then their approval is considered revoked.'
> 
> I believe this happens because if we use "Review changes" to add a comment, it will add a review with `Review.Verdict.NONE` to our pr.  According to our current logic, this new review will cover old reviews, so the approval will be revoked.
> 
> I made changes to `CheckablePullRequest#filterActiveReviews`. Now If latest review is just a comment, the verdict will inherit from the previous review.

This pull request has now been integrated.

Changeset: ee75ee0a
Author:    Zhao Song <zsong at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/ee75ee0a81c3098576c559b2bc9bd5317042a8a2
Stats:     67 lines in 2 files changed: 65 ins; 0 del; 2 mod

1587: Adding review comments should not mean approval status change

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1399