RFR: 1450: Jcheck status message can be too big for Gitlab [v2]

Erik Joelsson erikj at openjdk.org
Wed Nov 2 16:53:10 UTC 2022

On Thu, 27 Oct 2022 16:19:22 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> SKARA-1450 describes the problem that the comment adding to a GitLab merge request can be too big to add and leads to fail. 
>> To fix it, I add the function `limitBodySize()` to `addComment()` and `updateComment()` in `GitLabMergeRequest`, the function will check the size of the comment and  the comment will be cropped if it is too big.
>> I also found that GitHub pull request might have the same problem, so I did the same change to `GitHubPullRequest`.
>> Currently, I set the comment max size to 20000, and I don't know whether it is fine. I think it could not be too small because the user wants to see more information and it should not be big because if it is too big, the page loading process will be slow when the user tries to open the pr.
>> [Maximum length for the comment body in GitHub PR](https://github.com/orgs/community/discussions/27190)
>> [My test in Playground](https://github.com/openjdk/playground/pull/99)
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   bump comment body size from 20000 to 64000

Marked as reviewed by erikj (Lead).


PR: https://git.openjdk.org/skara/pull/1403

More information about the skara-dev mailing list