RFR: 1582: /integrate defer should be named /integrate delegate [v3]

Erik Joelsson erikj at openjdk.org
Wed Nov 2 16:56:28 UTC 2022


On Thu, 27 Oct 2022 20:48:47 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In this patch, to make the user has better experience, the command `/integrate defer` has been updated to `/integrate delegate` and the command `/integrate undefer` has been updated to `/integrate undelegate`.
>> 
>> `/integrate defer` and `/integrate undefer` are still valid. But warning message will be printed when these two commands are used.
>> 
>> After this patch is merged, the wiki page [/integrate](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate) should be updated.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed bug in IntegrateTests

bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 55:

> 53: 
> 54:     private void showHelp(PrintWriter reply) {
> 55:         reply.println("usage: `/integrate [auto|manual|delegate|undelegate<hash>]`");

Looks like you lost a `|`.

-------------

PR: https://git.openjdk.org/skara/pull/1404


More information about the skara-dev mailing list