Integrated: 1450: Jcheck status message can be too big for Gitlab
Zhao Song
zsong at openjdk.org
Wed Nov 2 20:02:54 UTC 2022
On Wed, 26 Oct 2022 23:03:56 GMT, Zhao Song <zsong at openjdk.org> wrote:
> SKARA-1450 describes the problem that the comment adding to a GitLab merge request can be too big to add and leads to fail.
>
> To fix it, I add the function `limitBodySize()` to `addComment()` and `updateComment()` in `GitLabMergeRequest`, the function will check the size of the comment and the comment will be cropped if it is too big.
>
> I also found that GitHub pull request might have the same problem, so I did the same change to `GitHubPullRequest`.
>
> Currently, I set the comment max size to 20000, and I don't know whether it is fine. I think it could not be too small because the user wants to see more information and it should not be big because if it is too big, the page loading process will be slow when the user tries to open the pr.
>
> [Maximum length for the comment body in GitHub PR](https://github.com/orgs/community/discussions/27190)
> [My test in Playground](https://github.com/openjdk/playground/pull/99)
This pull request has now been integrated.
Changeset: 804b7e95
Author: Zhao Song <zsong at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.org/skara/commit/804b7e95f8e623b43192d87476f38fa4a3c156ee
Stats: 67 lines in 4 files changed: 67 ins; 0 del; 0 mod
1450: Jcheck status message can be too big for Gitlab
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1403
More information about the skara-dev
mailing list