RFR: 1663: Mark integrated Pull Requests as properly merged in GitHub repositories

Erik Joelsson erikj at openjdk.org
Thu Nov 3 17:04:25 UTC 2022

On Thu, 3 Nov 2022 15:09:57 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> That's a bit of a bummer, though maybe that can be circumvented with a few instanceof GitHubPullRequests? The change is, after all, only actually implemented for GitHub

I don't understand what you mean by the change only being implemented for GitHub. We strive to keep Skara feature equivalent on GitHub and GitLab.

The pr/X branch feature is optional, so those branches are currently not present in all repositories that the PR bot operates on. This configuration is done in the notifier bot, as that is currently the only bot that needs to know about it, so the PR bot does not know if the feature is active. It would have to check for the presence of such a branch at integration time, and we would have to trust that no other branches with such names ever show up in repos where we haven't activated the pr/X feature.

I don't think the proposed strategy of using the pr/X branches to trick the forge into marking a PR as "merged" is viable for us. To me, the tradeoff between extra complications and the potential gain isn't worth it.


PR: https://git.openjdk.org/skara/pull/1409

More information about the skara-dev mailing list