RFR: 1660: Add confname field to slack log config [v2]

Magnus Ihse Bursie ihse at openjdk.org
Tue Nov 8 09:03:50 UTC 2022

On Fri, 4 Nov 2022 13:58:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The Slack log handler currently takes a "username" value as input which if set is sent to Slack as the user name of the message. With modern webhooks, it unfortunately seems that we have lost the feature of overriding the user name of a message. Our current configs put a descriptive string identifying the bot configuration in this field, which we can no longer see.
>> I want to add a specific new configuration field to the Slack log handler for the "configname". If set, this will appear first in every Slack message.
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>   Change configname to prefix

The patch looks good. but I'm thinking if you should use some delimiter for the prefix, like `[` ... `]`. Or is the plan to make formatting for the prefix to be clearly marked as a prefix in the configuration? (I'm just worried that if this is not done properly it can be hard to distinguish the prefix from the message proper, making it look odd)


Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/skara/pull/1413

More information about the skara-dev mailing list