RFR: 1658: Minimize race window when updating PR body [v2]

Magnus Ihse Bursie ihse at openjdk.org
Wed Nov 9 10:16:17 UTC 2022

On Wed, 9 Nov 2022 00:43:30 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> test/src/main/java/org/openjdk/skara/test/TestIssue.java line 94:
>>> 92:     @Override
>>> 93:     public String body() {
>>> 94:         return body;
>> Make `TestIssue#body()` consistent with `GitHubPullRequest#body()` and `GitLabMergeRequest#body()`.
>> It was returning the latest body from the 'remote' instead of the cache. So it is different from `GitHubPullRequest` and `GitLabMergeRequest`
> This change would make some tests fail. We need to update the tests, and I wonder whether it is better to file another bug to make this change and update related tests.

In effect, it sounds like `TestIssue` did not properly mimick the real classes. So fixing this, and fixing the tests so they pass, is probably a good idea. Maybe you should do that separately, yes, and integrate that first. Then you can easily add a proper test to this PR.


PR: https://git.openjdk.org/skara/pull/1416

More information about the skara-dev mailing list