RFR: 1655: A PR/commit with an invalid jcheck config should be caught by jcheck [v6]

Erik Joelsson erikj at openjdk.org
Tue Nov 15 19:35:55 UTC 2022

On Tue, 8 Nov 2022 02:33:47 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> SKARA-1655 describes a problem related with invalid jcheck config in a new change.
>> Currently, Skara never checks if the jcheck config is changed in a new change. So for example, if we accidentally
>> changed the jcheck config in a change and it was bad formatted, the bot will be in a retry loop and stuck.
>> In this patch, `JCheckConfCheck` is added to JCheck. If this check is configured, jcheck will check whether the jcheck config is still valid in the new change. If it is not, the specific problem will be added to the PR body and this PR will be blocked to be `ready for review`.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   update test

Does this change depend on #1407 for the test to pass?


Marked as reviewed by erikj (Lead).

PR: https://git.openjdk.org/skara/pull/1415

More information about the skara-dev mailing list