RFR: 1670: Make body handling consistent in all Issue implementations
Erik Joelsson
erikj at openjdk.org
Tue Nov 15 19:47:37 UTC 2022
On Wed, 9 Nov 2022 19:06:40 GMT, Zhao Song <zsong at openjdk.org> wrote:
> When fixing [SKARA-1658](https://bugs.openjdk.org/browse/SKARA-1658), I found the `TestIssue#body` didn't mimic `GitHubPullRequest#body` and` GitLabMergeRequest#body` properly. So this will block SKARA-1658.
>
> The `body()` method in `TestIssue` always returns the latest body from the 'remote' instead of the cache. So it behaves different from GitHubPullRequest and GitLabMergeRequest.
>
> In this patch, `TestIssue#body` will return the cached body like `GitHubPullRequest#body` and `GitLabMergeRequest#body`. Also updated related tests.
Good that you made this a separate change and good catch.
-------------
Marked as reviewed by erikj (Lead).
PR: https://git.openjdk.org/skara/pull/1417
More information about the skara-dev
mailing list