RFR: 1393: PR bot fails on missing .jcheck/conf [v5]

Zhao Song zsong at openjdk.org
Tue Nov 15 22:20:08 UTC 2022


On Tue, 15 Nov 2022 19:06:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Used UncheckedRestException
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/LimitedCensusInstance.java line 57:
> 
>> 55:             var census = Census.parse(repoFolder);
>> 56:             var namespace = namespace(census, repository.namespace());
>> 57:             return Optional.of(new LimitedCensusInstance(census, configuration, namespace));
> 
> No need to return `Optional` here anymore as we throw exception when the configuration is missing.

Exactly! I will remove it.

-------------

PR: https://git.openjdk.org/skara/pull/1407


More information about the skara-dev mailing list