RFR: 1393: PR bot fails on missing .jcheck/conf [v12]

Erik Joelsson erikj at openjdk.org
Wed Nov 16 21:02:17 UTC 2022


On Wed, 16 Nov 2022 19:10:20 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> SKARA-1393 describes a problem related with `.jcheck/conf` missing.
>> 
>> In this patch, when the problem happens, the author of this pull request will get instructions about how to solve this problem.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make TestHostedRepository#fileContents behave more like remote repos

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 236:

> 234:         } catch (MissingJCheckConfException e) {
> 235:             if (bot.confOverrideRepository().isEmpty()) {
> 236:                 log.info("No .jcheck/conf found in repo " + bot.repo().name() + ": " + e);

I think we want SEVERE log messages with the exception included for all the cases here.

-------------

PR: https://git.openjdk.org/skara/pull/1407


More information about the skara-dev mailing list