RFR: 1393: PR bot fails on missing .jcheck/conf [v12]

[Erik Joelsson]

On Wed, 16 Nov 2022 21:09:56 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 236:
>> 
>>> 234:         } catch (MissingJCheckConfException e) {
>>> 235:             if (bot.confOverrideRepository().isEmpty()) {
>>> 236:                 log.info("No .jcheck/conf found in repo " + bot.repo().name() + ": " + e);
>> 
>> I think we want SEVERE log messages with the exception included for all the cases here.
>
>> I think we want SEVERE log messages with the exception included for all the cases here.
> 
> I thought if the jcheck configuration file is not overridden, we just need to tell the user to contact the repo owner and only the repo owner could fix this problem, admin could not. 
> 
> For the case that  jcheck configuration file is  overridden, we need to notify the admin because admin could fix this problem.
> 
> But it is also reasonable to notify admin in the first case, maybe the admin could contact the repo owner too.

Your reasoning is valid, but I think it's better that we get notified as admins too. We need to help repo owners with getting things right, also logging the exception gives us access to the stack trace which can help diagnose further.

-------------

PR: https://git.openjdk.org/skara/pull/1407