RFR: 1655: A PR/commit with an invalid jcheck config should be caught by jcheck [v7]

Zhao Song zsong at openjdk.org
Thu Nov 17 17:58:02 UTC 2022

> SKARA-1655 describes a problem related with invalid jcheck config in a new change.
> Currently, Skara never checks if the jcheck config is changed in a new change. So for example, if we accidentally
> changed the jcheck config in a change and it was bad formatted, the bot will be in a retry loop and stuck.
> In this patch, `JCheckConfCheck` is added to JCheck. If this check is configured, jcheck will check whether the jcheck config is still valid in the new change. If it is not, the specific problem will be added to the PR body and this PR will be blocked to be `ready for review`.

Zhao Song has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:

 - Merge branch 'master' into SKARA-1655
   # Conflicts:
   #	bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
 - update test
 - update JCheckConfCheckTests
 - update test again
 - update JCheckConfCheckTests
 - update test
 - SKARA-1655


Changes: https://git.openjdk.org/skara/pull/1415/files
 Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1415&range=06
  Stats: 365 lines in 9 files changed: 364 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1415.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1415/head:pull/1415

PR: https://git.openjdk.org/skara/pull/1415

More information about the skara-dev mailing list