Integrated: 1655: A PR/commit with an invalid jcheck config should be caught by jcheck

Zhao Song zsong at openjdk.org
Thu Nov 17 20:44:07 UTC 2022


On Mon, 7 Nov 2022 23:19:55 GMT, Zhao Song <zsong at openjdk.org> wrote:

> SKARA-1655 describes a problem related with invalid jcheck config in a new change.
> 
> Currently, Skara never checks if the jcheck config is changed in a new change. So for example, if we accidentally
> changed the jcheck config in a change and it was bad formatted, the bot will be in a retry loop and stuck.
> 
> In this patch, `JCheckConfCheck` is added to JCheck. If this check is configured, jcheck will check whether the jcheck config is still valid in the new change. If it is not, the specific problem will be added to the PR body and this PR will be blocked to be `ready for review`.

This pull request has now been integrated.

Changeset: d0c9af0d
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/d0c9af0dc8ed55a7d0ec36cc2457eff35fb8e712
Stats:     365 lines in 9 files changed: 364 ins; 0 del; 1 mod

1655: A PR/commit with an invalid jcheck config should be caught by jcheck

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1415


More information about the skara-dev mailing list