RFR: 1683: The force push notifier needs an overhaul
Zhao Song
zsong at openjdk.org
Tue Nov 22 22:02:13 UTC 2022
A user reported a bug related with the force-push notification. Erik investigated it and found the implementation of this notification should not be in the `PullRequestBranchNotifier`. Also, users preferred to not get force-push notification if the force-push happens when the pr is in draft state.
In this patch, the implementation of checking force-push and notifying user are moved to `CheckWorkItem`. Also, force-pushing or rebasing a draft pr will not warn user any more.
-------------
Commit messages:
- delete two blank lines
- SKARA-1683
Changes: https://git.openjdk.org/skara/pull/1426/files
Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1426&range=00
Issue: https://bugs.openjdk.org/browse/SKARA-1683
Stats: 307 lines in 8 files changed: 197 ins; 109 del; 1 mod
Patch: https://git.openjdk.org/skara/pull/1426.diff
Fetch: git fetch https://git.openjdk.org/skara pull/1426/head:pull/1426
PR: https://git.openjdk.org/skara/pull/1426
More information about the skara-dev
mailing list