RFR: 1683: The force push notifier needs an overhaul

Zhao Song zsong at openjdk.org
Tue Nov 22 23:54:43 UTC 2022

On Tue, 22 Nov 2022 23:35:15 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> A user reported a bug related with the force-push notification. Erik investigated it and found the implementation of this notification should not be in the `PullRequestBranchNotifier`. Also, users preferred to not get force-push notification if the force-push happens when the pr is in draft state.
>> In this patch, the implementation of checking force-push and notifying user are moved to `CheckWorkItem`. Also, force-pushing or rebasing a draft pr will not warn user any more.
> test/src/main/java/org/openjdk/skara/test/TestPullRequestStore.java line 132:
>> 130:     public void setDraft(boolean draft) {
>> 131:         this.draft = draft;
>> 132:         if(!draft){
> Suggestion:
>         if (!draft) {

> Nice work! I have some comments, but nothing really major.
> I put in some style corrections in some places. Please try to match the existing style with whitespace between keyword and opening paren as well as closing paren and opening brace.

My bad, I have the habit of using intellij to automatically adjust the format, but this time I forgot at some places, I will fix it.


PR: https://git.openjdk.org/skara/pull/1426

More information about the skara-dev mailing list