RFR: 1683: The force push notifier needs an overhaul

Zhao Song zsong at openjdk.org
Wed Nov 23 00:04:00 UTC 2022

On Tue, 22 Nov 2022 23:40:10 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I'm not sure if we should put this check here in `CheckWorkItem`. This will cause it to be run quite often. Maybe it would be better to put it in `CheckRun` where it would be guarded by the check metadata condition, so it would only need to be run if something significant has changed since the last check.

I think this is already guarded by the check metadata condition. It will only be executed when `currentCheckValid(census, comments, activeReviews, labels)` is false. The if clause is very long(line 273-425).


PR: https://git.openjdk.org/skara/pull/1426

More information about the skara-dev mailing list