Integrated: 1682: PullRequestBot::getPeriodicItems takes too long

Erik Joelsson erikj at
Wed Nov 23 19:04:49 UTC 2022

On Thu, 17 Nov 2022 22:57:25 GMT, Erik Joelsson <erikj at> wrote:

> Similar to the NotifyBot in [SKARA-1680](, the PullRequestBot is also suffering from spending a very long time in the very first round of getPeriodicItems after a bot restart. The last time we redeployed this bot, it took ~40 minutes. This was long enough to trigger several users to ask if Skara was having issues.
> The cause is similar. There is an `isReady` call for each PR, which checks for comments. The comment checking here is even worse than for the NotifyBot because every PR is checked for comments, not just those that match the "rfr" or "integrated" labels.
> My proposed solution is similar. We need to move this expensive evaluation to the relevant WorkItems where they can run concurrently instead of serially in `getPeriodicItems`. I chose to make the call from the abstract superclass `PullRequestWorkItem`. This does add the check unnecessarily to the `LabelerWorkItem`, but that one is running so rarely that I don't think it matters performance wise. For correctness, I don't think it hurts checking an extra time.

This pull request has now been integrated.

Changeset: 312a3122
Author:    Erik Joelsson <erikj at>
Stats:     98 lines in 5 files changed: 51 ins; 33 del; 14 mod

1682: PullRequestBot::getPeriodicItems takes too long

Reviewed-by: zsong, ihse



More information about the skara-dev mailing list