Integrated: 1683: The force push notifier needs an overhaul

Zhao Song zsong at
Wed Nov 23 22:02:57 UTC 2022

On Tue, 22 Nov 2022 21:57:58 GMT, Zhao Song <zsong at> wrote:

> A user reported a bug related with the force-push notification. Erik investigated it and found the implementation of this notification should not be in the `PullRequestBranchNotifier`. Also, users preferred to not get force-push notification if the force-push happens when the pr is in draft state.
> In this patch, the implementation of checking force-push and notifying user are moved to `CheckWorkItem`. Also, force-pushing or rebasing a draft pr will not warn user any more.

This pull request has now been integrated.

Changeset: d0bd0019
Author:    Zhao Song <zsong at>
Stats:     313 lines in 9 files changed: 193 ins; 109 del; 11 mod

1683: The force push notifier needs an overhaul

Reviewed-by: erikj



More information about the skara-dev mailing list