Integrated: 1683: The force push notifier needs an overhaul
Zhao Song
zsong at openjdk.org
Wed Nov 23 22:02:57 UTC 2022
On Tue, 22 Nov 2022 21:57:58 GMT, Zhao Song <zsong at openjdk.org> wrote:
> A user reported a bug related with the force-push notification. Erik investigated it and found the implementation of this notification should not be in the `PullRequestBranchNotifier`. Also, users preferred to not get force-push notification if the force-push happens when the pr is in draft state.
>
> In this patch, the implementation of checking force-push and notifying user are moved to `CheckWorkItem`. Also, force-pushing or rebasing a draft pr will not warn user any more.
This pull request has now been integrated.
Changeset: d0bd0019
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/d0bd0019e2c36f815952b0d80630fc53aae1d0ce
Stats: 313 lines in 9 files changed: 193 ins; 109 del; 11 mod
1683: The force push notifier needs an overhaul
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1426
More information about the skara-dev
mailing list