RFR: 1658: Minimize race window when updating PR body [v5]

[Erik Joelsson]

On Tue, 29 Nov 2022 17:57:53 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, when the pr bot tries to update the PR body, users are also likely to update the PR body at the same time. Therefore, users' updates are likely to be overwritten by bot.  
>> 
>> This is a race between the bot and user and the race window is a little big right now.
>> 
>> To reduce the race window, in this patch, when PR bot is trying to update PR body, it will check whether the PR body has been modified by user. And if the PR bot has been modified, PR bot would not overwrite it.
>
> Zhao Song has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into SKARA-1658
>    
>    # Conflicts:
>    #	bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
>    #	forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java
>    #	forge/src/test/java/org/openjdk/skara/forge/github/GitHubRestApiTests.java
>  - Merge branch 'master' into SKARA-1658
>    
>    # Conflicts:
>    #	bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
>  - Merge branch 'master' into SKARA-1658
>  - Added an automatic test for latestBody
>  - SKARA-1658

Looks like I forgot to publish the review for these comments yesterday. Sorry about that.

-------------

PR: https://git.openjdk.org/skara/pull/1416