RFR: 1658: Minimize race window when updating PR body [v2]

Zhao Song zsong at openjdk.org
Tue Nov 29 23:57:40 UTC 2022


On Tue, 15 Nov 2022 19:42:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added an automatic test for latestBody
>
> forge/src/main/java/org/openjdk/skara/forge/PullRequest.java line 252:
> 
>> 250:     }
>> 251: 
>> 252:     String latestBody();
> 
> I'm not sure of this method. We could just fetch a new `PullRequest` instance and read the body from that, and I don't think there is any real overhead in doing so.

Will change it.

-------------

PR: https://git.openjdk.org/skara/pull/1416


More information about the skara-dev mailing list