RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v3]

Kevin Rushforth kcr at openjdk.org
Wed Nov 30 19:52:58 UTC 2022

On Wed, 30 Nov 2022 19:37:24 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   implemented case 5
> vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1699:
>> 1697:                 author, ZonedDateTime.now(), List.of(""));
>> 1698:         return new Commit(commitMetaData, List.of(diff(head())));
>> 1699:     }
> I tried to implement case 5 by Erik's idea. It seems work fine. But I don't know whether my implementation is acceptable, like the author and hash in the fake commit.

I'd be more worried about what it might do to my current index or working tree. Is there any chance things could go badly and mess that up?


PR: https://git.openjdk.org/skara/pull/1428

More information about the skara-dev mailing list