From erik.joelsson at oracle.com Mon Oct 3 14:54:36 2022 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Mon, 3 Oct 2022 07:54:36 -0700 Subject: Automatic replacement of 8-pool by the specific version In-Reply-To: <28e98448-3119-3ddf-9a1f-6f131d51076d@amazon.com> References: <28e98448-3119-3ddf-9a1f-6f131d51076d@amazon.com> Message-ID: <4f17a2bc-5ccf-1ebd-dec1-4ea78e80d387@oracle.com> On 9/28/22 15:28, Sergey Bylokhov wrote: > Hello, > > I few years ago the "Fix Version" equal to 8-pool is automatically > updated by the hgupdater to the specific version. For example > https://bugs.openjdk.org/browse/JDK-8266348 where "8-pool" was > replaced by the "8u311". But looks like now it stopped working: > https://bugs.openjdk.org/browse/JDK-8293461, note that a new backport > was created for "openjdk8u362". Is it intentional change or it is a > bug somewhere? > That is not intentional. X-pool records are supposed to be consumed as you describe. I will investigate. /Erik From duke at openjdk.org Mon Oct 3 22:28:14 2022 From: duke at openjdk.org (Zhao Song) Date: Mon, 3 Oct 2022 22:28:14 GMT Subject: RFR: 1215: Clean label not updating correctly Message-ID: Originally, If the user mistakenly creates a Backport PR with the wrong hash and then later corrects it, the clean status is never correctly re-evaluated. Currently, If the user correct the hash, the bot will be forced to do the check again and could correctly add clean label. ------------- Commit messages: - Make clean label updating correctly Changes: https://git.openjdk.org/skara/pull/1388/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1388&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-1215 Stats: 128 lines in 2 files changed: 126 ins; 0 del; 2 mod Patch: https://git.openjdk.org/skara/pull/1388.diff Fetch: git fetch https://git.openjdk.org/skara pull/1388/head:pull/1388 PR: https://git.openjdk.org/skara/pull/1388 From erikj at openjdk.org Tue Oct 4 13:45:56 2022 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 4 Oct 2022 13:45:56 GMT Subject: RFR: 1452: Can never notify on first commit [v2] In-Reply-To: References: Message-ID: On Thu, 29 Sep 2022 22:02:22 GMT, Zhao Song wrote: >> I changed the logic when there is no notify history. >> >> Originally, on the first commit of a new repo, the bot would find no notify history, so it will make the first commit as an initial state and it will not make any notification. >> >> Now, on the first commit of a new repo, the bot would find no notify history too, but it will make the initial git hash as the initial state of the repo, so it will treat the first commit as an 'update' operation and will make notifications. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > fix some bugs in MailingListNotifierTests Solving this is more complex. I added more information to the bug. ------------- PR: https://git.openjdk.org/skara/pull/1385 From erikj at openjdk.org Tue Oct 4 13:53:23 2022 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 4 Oct 2022 13:53:23 GMT Subject: RFR: 1563: The method 'CheckRun#updateMergeReadyComment' shouldn't update the comment if the comment has not changed [v3] In-Reply-To: References: Message-ID: On Fri, 30 Sep 2022 19:05:29 GMT, Zhao Song wrote: >> Do not update comment if the comment already exists. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > dummy commit to see whether the macOS test fail is occasional bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 938: > 936: pr.updateComment(existing.get().id(), message); > 937: } else { > 938: log.info("Merge ready comment already exists, no need to update the comment"); Suggestion: log.info("Merge ready comment already exists, no need to update"); bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 947: > 945: pr.updateComment(existing.get().id(), message); > 946: } else { > 947: log.info("No longer ready comment already exists, no need to update the comment"); Suggestion: log.info("No longer ready comment already exists, no need to update"); ------------- PR: https://git.openjdk.org/skara/pull/1386 From erikj at openjdk.org Tue Oct 4 14:18:46 2022 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 4 Oct 2022 14:18:46 GMT Subject: RFR: 1603: Make labels handling consistent in all Issue implementations In-Reply-To: References: Message-ID: On Fri, 30 Sep 2022 20:18:42 GMT, Zhao Song wrote: > Make TestIssue and JiraIssue update the cache when updating labels. issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 287: > 285: @Override > 286: public void setLabels(List labels) { > 287: this.labels = null; Both `GitHubPullRequest` and `GitHubMergeRequest` update the internal `labels` field in this method instead of making it null. issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java line 301: > 299: @Override > 300: public List