RFR: 1452: Can never notify on first commit [v2]

Erik Joelsson erikj at openjdk.org
Tue Oct 4 13:45:56 UTC 2022


On Thu, 29 Sep 2022 22:02:22 GMT, Zhao Song <duke at openjdk.org> wrote:

>> I changed the logic when there is no notify history.
>> 
>> Originally, on the first commit of a new repo, the bot would find no notify history, so it will make the first commit as an initial state and it will not make any notification.
>> 
>> Now, on the first commit of a new repo, the bot would find no notify history too, but it will make the initial git hash as the initial state of the repo, so it will treat the first commit as an 'update' operation and will make notifications.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix some bugs in MailingListNotifierTests

Solving this is more complex. I added more information to the bug.

-------------

PR: https://git.openjdk.org/skara/pull/1385


More information about the skara-dev mailing list