RFR: 1452: Can never notify on first commit [v3]

Zhao Song zsong at openjdk.org
Thu Oct 6 19:00:54 UTC 2022

On Thu, 6 Oct 2022 18:25:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   set a threshold to determine whether should notify on first commit
> bots/notify/src/test/java/org/openjdk/skara/bots/notify/mailinglist/MailingListNotifierTests.java line 84:
>> 82:             updater.attachTo(notifyBot);
>> 83: 
>> 84:             // One mail should be sent on first commit
> So all these tests needed to be modified because the test repos are so small the fall below the threshold?

Yes, our existing tests all just have few commits, and the commit counts are all  below the threshold, so I added a test with a repo which has 'long' history.


PR: https://git.openjdk.org/skara/pull/1385

More information about the skara-dev mailing list