RFR: 1452: Can never notify on first commit [v7]

Zhao Song zsong at openjdk.org
Fri Oct 7 16:38:52 UTC 2022


On Fri, 7 Oct 2022 16:35:33 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> I changed the logic when there is no notify history.
>> 
>> Originally, on the first commit of a new repo, the bot would find no notify history, so it will make the first commit as an initial state and it will not make any notification.
>> 
>> Now, on the first commit of a new repo, the bot would find no notify history too, but it will make the initial git hash as the initial state of the repo, so it will treat the first commit as an 'update' operation and will make notifications.
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - fix a bug
>  - add a method ReadOnlyRepository#initialHash

vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java line 173:

> 171:     int commitCount() throws IOException;
> 172: 
> 173:     Hash initialHash();

Since the initial hash is called differently in Git Repo and Hg Repo, so I named the method initialHash.I don't know if this is appropriate.

-------------

PR: https://git.openjdk.org/skara/pull/1385


More information about the skara-dev mailing list