RFR: 1584: Require re-review of a PR if the target branch changes [v3]
Erik Joelsson
erikj at openjdk.org
Fri Oct 7 18:16:21 UTC 2022
On Fri, 7 Oct 2022 12:06:45 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> Erik Joelsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into SKARA-1584-rereview-targetref
>> - Merge branch 'master' into SKARA-1584-rereview-targetref
>> - SKARA-1584
>
> forge/src/main/java/org/openjdk/skara/forge/RefChange.java line 5:
>
>> 3: import java.time.ZonedDateTime;
>> 4:
>> 5: public record RefChange(String prevRefName, String curRefName, ZonedDateTime createdAt) {
>
> Again, I'm more for shorter names, so I would have gone with `ReferenceChange(String from, String to, ZonedDateTime at)`
I like that.
-------------
PR: https://git.openjdk.org/skara/pull/1383
More information about the skara-dev
mailing list