RFR: 1629: Limit how far back maxUpdatedAt can be set in PullRequestPoller [v2]

Erik Joelsson erikj at openjdk.org
Thu Oct 13 14:11:31 UTC 2022

> After having observed the PullRequestPoller in action for a bit, I've noticed some weird behavior. Say a very old open PR A exists, and there is a closed PR B that is newer (but older than the 7 day initial query limit). Then on the first round, PR A will be returned and maxUpdatedAt will be set to updatedAt of PR A. On the second round, this will cause PR B to be returned. This is causing some weird behavior, resurrecting very old closed PRs that have problems with them.
> This patch fixes this by putting a hard limit on how far back we query for the updatedAt field.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Recalculate limit dynamically


  - all: https://git.openjdk.org/skara/pull/1395/files
  - new: https://git.openjdk.org/skara/pull/1395/files/80cdb0f3..380d74a9

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1395&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1395&range=00-01

  Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/skara/pull/1395.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1395/head:pull/1395

PR: https://git.openjdk.org/skara/pull/1395

More information about the skara-dev mailing list