Integrated: 1629: Limit how far back maxUpdatedAt can be set in PullRequestPoller
Erik Joelsson
erikj at openjdk.org
Thu Oct 13 14:11:32 UTC 2022
On Tue, 11 Oct 2022 21:09:55 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> After having observed the PullRequestPoller in action for a bit, I've noticed some weird behavior. Say a very old open PR A exists, and there is a closed PR B that is newer (but older than the 7 day initial query limit). Then on the first round, PR A will be returned and maxUpdatedAt will be set to updatedAt of PR A. On the second round, this will cause PR B to be returned. This is causing some weird behavior, resurrecting very old closed PRs that have problems with them.
>
> This patch fixes this by putting a hard limit on how far back we query for the updatedAt field.
This pull request has now been integrated.
Changeset: f38133df
Author: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.org/skara/commit/f38133dfbf725df614324486a847714e2cb56070
Stats: 37 lines in 2 files changed: 34 ins; 0 del; 3 mod
1629: Limit how far back maxUpdatedAt can be set in PullRequestPoller
Reviewed-by: ehelin
-------------
PR: https://git.openjdk.org/skara/pull/1395
More information about the skara-dev
mailing list