RFR: 1627: Add tests for bot factories [v3]

[Erik Joelsson]

On Mon, 17 Oct 2022 18:37:57 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> test/src/main/java/org/openjdk/skara/test/TestBotFactory.java line 160:
>> 
>>> 158:     }
>>> 159: 
>>> 160:     public List<Bot> createBots(String name, JSONObject configuration) {
>> 
>> This is a copy of the method above. They should share implementation. You can make `create` call `createBots` and keep lines 151 to 154 to convert the list.
>
>> This is a copy of the method above. They should share implementation. You can make `create` call `createBots` and keep lines 151 to 154 to convert the list.
> 
> Ok, but the implementations of `continuousIntegration` and `repository` in `BotConfiguration` are a little different between `create` and `createBots`. Hope it will not affect other tests, although I don't think it's going to have any bad effects.

Ah I didn't realize you changed them. Ideally we should be able to have a unified implementation.

-------------

PR: https://git.openjdk.org/skara/pull/1393