RFR: 1587: Adding review comments should not mean approval status change

Zhao Song zsong at openjdk.org
Thu Oct 20 19:01:37 UTC 2022

On Thu, 20 Oct 2022 18:47:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I don't think we should create a new `Review` here. I _think_ that the way to achieve the desired behavior is to ignore reviews where the verdict isn't `APPROVED` or `DISAPPROVED`. A `Review` with verdict `NONE` is essentially pointless when considering active reviews.

Ah, exactly! Thanks for the suggestion! I will change it.


PR: https://git.openjdk.org/skara/pull/1399

More information about the skara-dev mailing list