RFR: 1587: Adding review comments should not mean approval status change [v3]

Erik Joelsson erikj at openjdk.org
Thu Oct 20 20:38:36 UTC 2022

On Thu, 20 Oct 2022 20:22:32 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> The issue here is ' if a user leaves additional comments using the "Review changes" dialog, and selects the "Comments", then their approval is considered revoked.'
>> I believe this happens because if we use "Review changes" to add a comment, it will add a review with `Review.Verdict.NONE` to our pr.  According to our current logic, this new review will cover old reviews, so the approval will be revoked.
>> I made changes to `CheckablePullRequest#filterActiveReviews`. Now If latest review is just a comment, the verdict will inherit from the previous review.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   Added a line breaker in CheckablePullRequest#filterActiveReviews and use pr.store() to do the test in testReviewCommentsAfterApprovedReview

Marked as reviewed by erikj (Lead).


PR: https://git.openjdk.org/skara/pull/1399

More information about the skara-dev mailing list