RFR: 1625: Validate input from /summary command

Zhao Song zsong at openjdk.org
Fri Oct 21 21:52:18 UTC 2022

On Fri, 21 Oct 2022 21:31:30 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > If exceptions are thrown when the bot is evaluating the current status of the pr, the exceptions will be treated as integration blocker.
> I didn't mean that any exception should be an integration blocker. I just wanted the very specific case when parsing the commit message fails to be one. For everything else, we should still let the exception go through.

Ok, my bad. I was thinking it is a little difficult to catch the specific exception. I look through the code again and find if the commit message is bad, `PullRequestCheckIssueVisitor` will throw `IllegalStateException`, so we just need to catch `IllegalStateException`, right?


PR: https://git.openjdk.org/skara/pull/1401

More information about the skara-dev mailing list