RFR: 1384: Cannot configure integrators for repositories in PullRequestBot
Erik Joelsson
erikj at openjdk.org
Mon Oct 24 17:33:50 UTC 2022
On Mon, 24 Oct 2022 17:04:28 GMT, Zhao Song <zsong at openjdk.org> wrote:
> Now, `PullRequestBotFactory` could parse the config `integrators`.
>
> Also fixed some whitespace issues in `PullRequestBotFactoryTest`
Looks good, even better having a test for it.
bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 170:
> 168: var integrators = repo.value().get("integrators")
> 169: .stream()
> 170: .map(integrator -> integrator.asString())
Suggestion:
.map(JSONValue::asString)
-------------
Marked as reviewed by erikj (Lead).
PR: https://git.openjdk.org/skara/pull/1402
More information about the skara-dev
mailing list