RFR: 1625: Validate input from /summary command [v5]

Erik Joelsson erikj at openjdk.org
Mon Oct 24 20:19:14 UTC 2022

On Mon, 24 Oct 2022 18:12:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> 1.  Added validation to SummaryCommand.
>> 2. If exceptions are thrown when the bot is evaluating the current status of the pr, the exceptions will be treated as integration blocker.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   fix a whitespace issue

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 239:

> 237:     public void visit(MessageIssue issue) {
> 238:         var message = String.join("\n", issue.commit().message());
> 239:         addFailureMessage(issue.check(), "Incorrectly formatted commit message: " + message);

I don't think a multiline value will format well as a failure message. The commit message is also printed in the status comment, so probably don't need to include it here. Maybe it would be a good idea to log the full message just in case.


PR: https://git.openjdk.org/skara/pull/1401

More information about the skara-dev mailing list