RFR: 1582: /integrate defer should be named /integrate delegate

Erik Joelsson erikj at openjdk.org
Thu Oct 27 20:19:29 UTC 2022


On Thu, 27 Oct 2022 18:19:06 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this patch, to make the user has better experience, the command `/integrate defer` has been updated to `/integrate delegate` and the command `/integrate undefer` has been updated to `/integrate undelegate`.
> 
> `/integrate defer` and `/integrate undefer` are still valid. But warning message will be printed when these two commands are used.
> 
> After this patch is merged, the wiki page [/integrate](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate) should be updated.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 145:

> 143:             pr.addLabel("delegated");
> 144:             if (commandArg == Command.defer) {
> 145:                 reply.println("FutureWarning: /integrate defer is deprecated and will be moved in a future version. Use /integrate delegate instead.");

Suggestion:

                reply.println("Warning: /integrate defer is deprecated and will be removed in a future version. Use `/integrate delegate` instead.");

bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 152:

> 150:         } else if (commandArg == Command.undefer || commandArg == Command.undelegate) {
> 151:             if (commandArg == Command.undefer) {
> 152:                 reply.println("FutureWarning: /integrate undefer is deprecated and will be moved in a future version. Use /integrate undelegate instead.");

Suggestion:

                reply.println("Warning: /integrate undefer is deprecated and will be removed in a future version. Use `/integrate undelegate` instead.");

-------------

PR: https://git.openjdk.org/skara/pull/1404


More information about the skara-dev mailing list