RFR: 1581: Commit command error message misleading

[Erik Joelsson]

On Thu, 27 Oct 2022 20:57:44 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch updated the warning message when a user is not authorized to use the command `/backport`, `/tag`, `/clean`.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 67:

> 65:             reply.println("To use the `/backport` command, you need to be in the OpenJDK [census](https://openjdk.org/census)"
> 66:                     + " and your GitHub account needs to be linked with your OpenJDK username"
> 67:                     + "([how to associate your GitHub account with your OpenJDK username]"

It looks like a space is missing after "username".

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CleanCommand.java line 55:

> 53:                     + " and your GitHub account needs to be linked with your OpenJDK username"
> 54:                     + "([how to associate your GitHub account with your OpenJDK username]"
> 55:                     + "(https://wiki.openjdk.org/display/skara#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername)).");

I don't think we need to change this message. It's not in the same category as the ones referenced in the bug. It was specifically the "contributor" reference that was misleading.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/TagCommand.java line 69:

> 67:                         + " and your GitHub account needs to be linked with your OpenJDK username"
> 68:                         + "([how to associate your GitHub account with your OpenJDK username]"
> 69:                         + "(https://wiki.openjdk.org/display/skara#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername)).");

Since we are only allowing integrators to use the tag command, then this message may be unnecessary. It could still serve as a safety net that the integrators are actually also in the census. For that we should move this check to after the integrators check. Also the same space is missing here after "username".

-------------

PR: https://git.openjdk.org/skara/pull/1405