RFR: 1575: Adjust the pull request APIs in HostedRepository [v2]

Erik Joelsson erikj at openjdk.org
Tue Sep 6 17:10:20 UTC 2022


On Fri, 2 Sep 2022 18:31:44 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch mainly has the following changes in `HostedRepository` and its sub-classes. And the usages of the changed methods are also changed.
>> 
>> 1. Change the name of the `pullRequests(ZonedDateTime updatedAfter)` to `pullRequestsAfter` so that it is consistent as the `openPullRequestsAfter`.
>> 2. Add the new api `openPullRequests` to get all the open pull requests.
>> 3. Change the implementation of the method `pullRequests()` to get all the pull requests (included open and closed)
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add parameter about max pages and order.

Marked as reviewed by erikj (Lead).

-------------

PR: https://git.openjdk.org/skara/pull/1367


More information about the skara-dev mailing list