RFR: 1199: Enforce maintainer approval in JBS before allowing to integrate backports into updates projects [v4]

Erik Joelsson erikj at openjdk.org
Tue Sep 6 17:34:58 UTC 2022

On Fri, 2 Sep 2022 21:23:35 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> After reading your comment, I think it is better to implement the approval feature in the pr module instead of adding the new approval module. Maybe we can begin the work in this patch?(Add the IssueBot and ApprovalWorkItem to the pr module) It seems not hard to achieve.

No, because then we add the implicit dependency on issue notifications to the PR module internals. I'm not ok with that.

> If we want to refator `csr`, `jep` and `approval` modules into `pr` module, it seems the NotifyBot can't influence it. Do you want to move the issue related feature from `notify` module to `pr` module so that it needs to think more? Or Could you explain more information about it?

I do not want to move too much into the pr bot, especially not any notification services. I merely tried to point out why it would be problematic to move Issue polling into the PR bot and that is something that needs to be figured out. I don't have the solution yet. I might have some vague ideas, but I'm not ready to share yet, mainly because I have more urgent issues to focus on atm.


PR: https://git.openjdk.org/skara/pull/1364

More information about the skara-dev mailing list