RFR: 1568: Dependency PR Resolution Detection Does Not Check Means of Resolution [v2]

Guoxiong Li gli at openjdk.org
Thu Sep 8 14:53:31 UTC 2022


On Thu, 8 Sep 2022 14:30:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add another comment about not integrated pull request.
>
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/prbranch/PullRequestBranchNotifier.java line 121:
> 
>> 119:                             request to be updated, which means that changes from the parent pull request will start to show up \
>> 120:                             in this pull request. If closing the parent pull request was done in error, it will need to be \
>> 121:                             re-opened and this pull request will need to be retargeted again manually.
> 
> Reading what I wrote again, I want to revise it a bit.
> Suggestion:
> 
>                             The parent pull request that this pull request depends on has been closed without being \ 
>                             integrated and the target branch of this pull request has been updated as the previous \
>                             branch was deleted. This means that changes from the parent pull request will start to \
>                             show up in this pull request. If closing the parent pull request was done in error, it will \
>                             need to be re-opened and this pull request will need to manually be retargeted again.

Fixed just now.

-------------

PR: https://git.openjdk.org/skara/pull/1365


More information about the skara-dev mailing list