RFR: 1589: Improve TestIssue and TestPullRequest [v2]

Erik Joelsson erikj at openjdk.org
Fri Sep 9 17:03:13 UTC 2022

On Fri, 9 Sep 2022 15:20:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> This is quite a massive PR. It took some time to look thought. I lost track of some changes but I think I got to the bottom of most of these. I can definitely see a drawback with using the "var" syntax when reviewing diffs on Github -- when I'm in the IDE I can get tooltips telling me about the type, but now I had to jump back and forth to look for definitions to understand how the code tied together.
> So in the end, I think it looks good. The fact that it is only test changes makes it definitely less risky.

Thank you for taking the time!


PR: https://git.openjdk.org/skara/pull/1370

More information about the skara-dev mailing list