RFR: 1589: Improve TestIssue and TestPullRequest [v3]
Erik Joelsson
erikj at openjdk.org
Sat Sep 10 13:23:09 UTC 2022
On Fri, 9 Sep 2022 23:13:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> I seem to have an intermittent failure in BackportsTest on Windows. Still trying to figure it out, so will hold off on this for now.
I believe I found the issue. In `TestIssue::equals` (and hashCode) I forgot to include the `id` field, so instances with different IDs but the same contents were considered the same, which would randomly confuse tests. If all GHA checks shows green, I think we are good to go.
-------------
PR: https://git.openjdk.org/skara/pull/1370
More information about the skara-dev
mailing list